Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(fee): remove resource mapping def from rpc 06 and 07 #557

Conversation

nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Aug 22, 2024

This change is Reviewable

@nimrod-starkware nimrod-starkware marked this pull request as ready for review August 22, 2024 05:47
@nimrod-starkware nimrod-starkware self-assigned this Aug 22, 2024
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_some_more branch from f92c17b to 0fc7eae Compare August 22, 2024 06:04
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_from_rpc06_07 branch from 2ec4a7a to 1787ae8 Compare August 22, 2024 06:04
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_some_more branch from 0fc7eae to c27e3e9 Compare August 22, 2024 09:06
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_from_rpc06_07 branch from 1787ae8 to 678aff1 Compare August 22, 2024 09:06
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_some_more branch from c27e3e9 to 68faa71 Compare August 22, 2024 09:10
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_from_rpc06_07 branch from 678aff1 to 07a6034 Compare August 22, 2024 09:10
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_some_more branch from 68faa71 to 4bb38de Compare August 22, 2024 09:36
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_from_rpc06_07 branch from 07a6034 to 36e98ce Compare August 22, 2024 09:37
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_some_more branch from 4bb38de to 228df1d Compare August 22, 2024 09:58
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_from_rpc06_07 branch from 36e98ce to f2f3efd Compare August 22, 2024 09:58
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 11 files at r1, all commit messages.
Reviewable status: 1 of 11 files reviewed, all discussions resolved (waiting on @ShahakShama)

@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_some_more branch from 228df1d to aea9822 Compare August 25, 2024 06:27
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_from_rpc06_07 branch from f2f3efd to 4a91b4e Compare August 25, 2024 06:27
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_some_more branch from aea9822 to 50f30a2 Compare August 25, 2024 08:14
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_from_rpc06_07 branch from 4a91b4e to 3a0c8e3 Compare August 25, 2024 08:15
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants